Skip to content

Conversation

@jackfrancis
Copy link
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This PR updates the version of coredns used during the CAPI workload cluster upgrade test to match the current version in CAPI main branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Apr 10, 2024
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and nojnhuh April 10, 2024 17:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2024
@jackfrancis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

FLATCAR_VERSION: "${FLATCAR_VERSION:-latest}"
ETCD_VERSION_UPGRADE_TO: "3.5.4-0"
COREDNS_VERSION_UPGRADE_TO: "v1.9.3"
COREDNS_VERSION_UPGRADE_TO: "v1.11.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 matches CAPI on the release-1.6 branch: https://github.com/kubernetes-sigs/cluster-api/blob/90d78fa0c57abacb88a9d158c61a47fe24cda229/test/e2e/config/docker.yaml#L322

Should we maybe bump etcd to 3.5.10-0 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Ace detective work @nojnhuh!

@jackfrancis jackfrancis force-pushed the workload-upgrade-coredns-v1.11.1 branch from 6740a31 to 336817f Compare April 10, 2024 18:51
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold to let the optional upgrade test finish.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eab38832cda9d9dfaf393ae46e544a94af3ecd4f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 10, 2024

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

@jackfrancis jackfrancis changed the title rev coredns version to v1.11.1 for upgrade test rev coredns and etcd version for upgrade test Apr 10, 2024
@codecov
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.73%. Comparing base (529ae97) to head (336817f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4715   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         192      192           
  Lines       15641    15641           
=======================================
  Hits         9812     9812           
  Misses       5146     5146           
  Partials      683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 10, 2024

upgrade job passed!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 411671c into kubernetes-sigs:main Apr 10, 2024
@jackfrancis jackfrancis deleted the workload-upgrade-coredns-v1.11.1 branch April 11, 2024 01:04
@nojnhuh
Copy link
Contributor

nojnhuh commented May 16, 2024

/cherry-pick release-1.14

I think this is holding up #4856.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #4857

In response to this:

/cherry-pick release-1.14

I think this is holding up #4856.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh mentioned this pull request May 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants